ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r501875691
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/HighAvailabilityTaskAssignorIntegrationTest.java
##########
@@ -286,7 +286,8 @@ private static Properties streamsProperties(final String
appId,
mkEntry(StreamsConfig.PROBING_REBALANCE_INTERVAL_MS_CONFIG,
"60000"),
mkEntry(StreamsConfig.InternalConfig.ASSIGNMENT_LISTENER,
configuredAssignmentListener),
mkEntry(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, "100"),
-
mkEntry(StreamsConfig.InternalConfig.INTERNAL_TASK_ASSIGNOR_CLASS,
HighAvailabilityTaskAssignor.class.getName())
+
mkEntry(StreamsConfig.InternalConfig.INTERNAL_TASK_ASSIGNOR_CLASS,
HighAvailabilityTaskAssignor.class.getName()),
+ mkEntry(StreamsConfig.NUM_STREAM_THREADS_CONFIG, 40)
Review comment:
Can we add a comment here explaining why we set the thread count so
high? I feel like we'll forget and be really confused when we stumble across
this in the future.
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfoTest.java
##########
@@ -59,6 +60,7 @@
);
private final static String IGNORED_USER_ENDPOINT =
"ignoredUserEndpoint:80";
+ private static final byte[] IGNORED_UNIQUE_FIELD = Bytes.EMPTY;
Review comment:
nit: let's use `new byte[1]` for this to make sure it's actually being
ignored when it should be (since apparently it won't notice if you just pass in
empty bytes for this field on a version < 8)
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##########
@@ -483,7 +485,7 @@ public void testEagerSubscription() {
Collections.sort(subscription.topics());
assertEquals(asList("topic1", "topic2"), subscription.topics());
- final SubscriptionInfo info = getInfo(UUID_1, prevTasks, standbyTasks);
Review comment:
Yeah, it should be `0` the first time you call it, then `1` the second
time, and then back to `0` again on the third call
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
