lct45 commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r501956905
########## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ########## @@ -483,7 +485,7 @@ public void testEagerSubscription() { Collections.sort(subscription.topics()); assertEquals(asList("topic1", "topic2"), subscription.topics()); - final SubscriptionInfo info = getInfo(UUID_1, prevTasks, standbyTasks); Review comment: > goes back and forth between the two expected values What do you mean by expected values? Toggling between the default of `0` and `1` after `partitionAssignor.subscriptionUserData` is called the first time? ########## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ########## @@ -483,7 +485,7 @@ public void testEagerSubscription() { Collections.sort(subscription.topics()); assertEquals(asList("topic1", "topic2"), subscription.topics()); - final SubscriptionInfo info = getInfo(UUID_1, prevTasks, standbyTasks); Review comment: > goes back and forth between the two expected values What do you mean by expected values? Toggling between the default of `0` and `1` after `partitionAssignor.subscriptionUserData` is called the first time? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org