ijuma commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r555116056
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -1832,8 +1916,10 @@ public void process(final Record<String, String> record)
{
}
}
- @Test
- public void shouldRespectTaskIdling() {
+ @ParameterizedTest(name = "Eos enabled = {0}")
+ @MethodSource("parameters")
Review comment:
The downside of this non standard naming approach is that one may end up
not running some tests and it would be pretty hard to spot. What if we used
`EnumSource` and had an enum `EosEnabled` with two values: `True` and `False`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
