ijuma commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r555124847



##########
File path: 
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -1832,8 +1916,10 @@ public void process(final Record<String, String> record) 
{
         }
     }
 
-    @Test
-    public void shouldRespectTaskIdling() {
+    @ParameterizedTest(name = "Eos enabled = {0}")
+    @MethodSource("parameters")

Review comment:
       Also, I was hoping that by using `EnumSource` with an appropriately 
named enum, you can avoid the string in `ParameterizedTest`. In that case, the 
duplicated bits are:
   1. The `EnumSource` line.
   2. The enum parameter in each test.
   Both are strongly typed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to