chia7712 commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r555118186
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -1832,8 +1916,10 @@ public void process(final Record<String, String> record)
{
}
}
- @Test
- public void shouldRespectTaskIdling() {
+ @ParameterizedTest(name = "Eos enabled = {0}")
+ @MethodSource("parameters")
Review comment:
> What if we used EnumSource and had an enum EosEnabled with two values:
True and False?
I assumed that we don't like duplication like ```@ParameterizedTest``` and
```XXXSource``` :)
Will apply ```EnumSource```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
