chia7712 commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r555130000
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -1832,8 +1916,10 @@ public void process(final Record<String, String> record)
{
}
}
- @Test
- public void shouldRespectTaskIdling() {
+ @ParameterizedTest(name = "Eos enabled = {0}")
+ @MethodSource("parameters")
Review comment:
> But ValueSource won't make it clear what true/false mean, right?
That's the main advantage of using the enum, we can make it clear what it means.
you are right. will copy that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
