cmccabe commented on a change in pull request #10113:
URL: https://github.com/apache/kafka/pull/10113#discussion_r578020912
##########
File path: core/src/main/scala/kafka/network/SocketServer.scala
##########
@@ -573,7 +584,7 @@ private[kafka] class Acceptor(val endPoint: EndPoint,
private def startProcessors(processors: Seq[Processor],
processorThreadPrefix: String): Unit = synchronized {
processors.foreach { processor =>
KafkaThread.nonDaemon(
-
s"${processorThreadPrefix}-kafka-network-thread-$brokerId-${endPoint.listenerName}-${endPoint.securityProtocol}-${processor.id}",
+
s"${processorThreadPrefix}-kafka-network-thread-$nodeId-${endPoint.listenerName}-${endPoint.securityProtocol}-${processor.id}",
Review comment:
When in combined mode (or in a JUnit test) we need a way to distinguish
the processor for controller node 0 from the process for broker node 0. Can we
just have a boolean we pass to indicate "this is a socket server for a
controller"?
That would also avoid the need to pass in an optional logcontext, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
