cmccabe commented on a change in pull request #10113:
URL: https://github.com/apache/kafka/pull/10113#discussion_r578021861
##########
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##########
@@ -70,7 +70,8 @@ object AlterIsrManager {
time: Time,
metrics: Metrics,
threadNamePrefix: Option[String],
- brokerEpochSupplier: () => Long
+ brokerEpochSupplier: () => Long,
+ brokerId: Int
Review comment:
why can't we use config.brokerId? Is this to support automatic broker
id assignment in the pre-KIP-500 code? It would be good to add a note to the
commit, if so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
