mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657891229
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java
##########
@@ -24,7 +24,7 @@
public final String idValue;
Review comment:
This package is part of the public API. I'm not sure we want to expose
`CoordinatorKey` which is currently only used internally.
That said,
[KIP-692](https://cwiki.apache.org/confluence/display/KAFKA/KIP-692%3A+Make+AdminClient+value+object+constructors+public)
proposes exposing the constructors of all the `*Result` classes. Maybe that
discussion should happen there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
