[GitHub] [kafka] mimaison commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

[GitBox]

mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657873384



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java
##########
@@ -24,7 +24,7 @@
     public final String idValue;
     public final FindCoordinatorRequest.CoordinatorType type;
 
-    private CoordinatorKey(String idValue, 
FindCoordinatorRequest.CoordinatorType type) {
+    public CoordinatorKey(FindCoordinatorRequest.CoordinatorType type, String 
idValue) {

Review comment:
       I was using it in `CoordinatorStrategy.handleResponse()` but I get 
easily get around it. It makes sense to keep it private




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org