mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r658016506
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -4806,7 +4275,7 @@ public ListTransactionsResult
listTransactions(ListTransactionsOptions options)
@Override
void handleResponse(AbstractResponse response) {
long currentTimeMs = time.milliseconds();
- driver.onResponse(currentTimeMs, spec, response);
+ driver.onResponse(currentTimeMs, spec, response,
nodeProvider.provide());
Review comment:
All of this is specifically because `ConsumerGroupDescription` needs the
coordinator as a `Node` when describing consumer groups.
At the moment, handlers only get the brokerId and that's not enough to build
a `Node` object. So instead in this PR, I replaced the `brokerId` argument by
the full `Node` object. The `brokerId` can be retrieved from `spec.scope` but
for the `Node`, we need to get that from the `Call` itself.
Good catch, `nodeProvider.provide()` could return a different `Node`! As far
as I can tell, we can use `curNode()` here, that should have been set by
`maybeDrainPendingCall()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
