showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r660562020
##########
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##########
@@ -60,6 +60,30 @@ class ConfigCommandTest extends ZooKeeperTestHarness with
Logging {
"--add-config", "security.inter.broker.protocol=PLAINTEXT"))
}
+ @Test
+ def shouldExitWithNonZeroStatusOnZkCommandWithTopicsEntity(): Unit = {
+ assertNonZeroStatusExit(Array(
+ "--zookeeper", zkConnect,
+ "--entity-type", "topics",
+ "--describe"))
+ }
+
+ @Test
+ def shouldExitWithNonZeroStatusOnZkCommandWithClientsEntity(): Unit = {
+ assertNonZeroStatusExit(Array(
+ "--zookeeper", zkConnect,
+ "--entity-type", "clients",
Review comment:
Will do. Thanks.
##########
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##########
@@ -60,6 +60,30 @@ class ConfigCommandTest extends ZooKeeperTestHarness with
Logging {
"--add-config", "security.inter.broker.protocol=PLAINTEXT"))
}
+ @Test
+ def shouldExitWithNonZeroStatusOnZkCommandWithTopicsEntity(): Unit = {
+ assertNonZeroStatusExit(Array(
+ "--zookeeper", zkConnect,
+ "--entity-type", "topics",
+ "--describe"))
+ }
+
+ @Test
+ def shouldExitWithNonZeroStatusOnZkCommandWithClientsEntity(): Unit = {
+ assertNonZeroStatusExit(Array(
+ "--zookeeper", zkConnect,
+ "--entity-type", "clients",
+ "--describe"))
+ }
+
+ @Test
+ def shouldExitWithNonZeroStatusOnZkCommandWithIpsEntity(): Unit = {
+ assertNonZeroStatusExit(Array(
+ "--zookeeper", zkConnect,
+ "--entity-type", "Ips",
Review comment:
Nice catch! Will update. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
