showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r661411622
##########
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##########
@@ -60,6 +60,39 @@ class ConfigCommandTest extends ZooKeeperTestHarness with
Logging {
"--add-config", "security.inter.broker.protocol=PLAINTEXT"))
}
+ @Test
+ def shouldExitWithNonZeroStatusOnZkCommandWithTopicsEntity(): Unit = {
+ assertNonZeroStatusExit(Array(
+ "--zookeeper", zkConnect,
+ "--entity-type", "topics",
+ "--describe"))
+ }
+
+ @Test
+ def shouldExitWithNonZeroStatusOnZkCommandWithClientsEntity(): Unit = {
+ assertNonZeroStatusExit(Array(
+ "--zookeeper", zkConnect,
+ "--entity-type", "clients",
+ "--describe"))
+ }
+
+ @Test
+ def shouldExitWithNonZeroStatusOnZkCommandWithIpsEntity(): Unit = {
+ assertNonZeroStatusExit(Array(
+ "--zookeeper", zkConnect,
+ "--entity-type", "ips",
+ "--describe"))
+ }
+
+ @Test
+ def shouldExitWithNonZeroStatusAlterUserQuotaWithoutEntityName(): Unit = {
Review comment:
> I was thinking this test should be exactly like the clients entity
case, why did we make it different?
Do you mean this test case?
```java
@Test
def shouldExitWithNonZeroStatusOnZkCommandWithClientsEntity(): Unit = {
assertNonZeroStatusExit(Array(
"--zookeeper", zkConnect,
"--entity-type", "clients",
"--describe"))
}
```
If so, it's because `users` entity can still accept to use ZK because we
need it to create/update the SCRAM credentials.
If this is not what you meant, please kindly let me know. Thank you. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
