jolshan commented on a change in pull request #10892:
URL: https://github.com/apache/kafka/pull/10892#discussion_r661066009
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DeleteTopicsResult.java
##########
@@ -30,24 +31,56 @@
*/
@InterfaceStability.Evolving
public class DeleteTopicsResult {
- final Map<String, KafkaFuture<Void>> futures;
+ private final Map<Uuid, KafkaFuture<Void>> topicIdFutures;
+ private final Map<String, KafkaFuture<Void>> nameFutures;
- protected DeleteTopicsResult(Map<String, KafkaFuture<Void>> futures) {
- this.futures = futures;
+ protected DeleteTopicsResult(Map<Uuid, KafkaFuture<Void>> topicIdFutures,
Map<String, KafkaFuture<Void>> nameFutures) {
+ if (topicIdFutures != null && nameFutures != null)
+ throw new IllegalArgumentException("topicIdFutures and nameFutures
can not both be specified.");
+ this.topicIdFutures = topicIdFutures;
+ this.nameFutures = nameFutures;
}
+ protected static DeleteTopicsResult ofTopicIds(Map<Uuid,
KafkaFuture<Void>> topicIdFutures) {
Review comment:
Forgive my ignorance but is that not the same thing? Is package private
just that we can't use in subclasses outside the package? If that's the case
then sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
