jolshan commented on a change in pull request #10892:
URL: https://github.com/apache/kafka/pull/10892#discussion_r661698641
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -1707,15 +1723,14 @@ public DeleteTopicsResult deleteTopics(final
Collection<String> topicNames,
final long now = time.milliseconds();
final long deadline = calcDeadlineMs(now, options.timeoutMs());
final Call call = getDeleteTopicsCall(options, topicFutures,
validTopicNames,
- Collections.emptyMap(), now, deadline);
+ Collections.emptyMap(), now, deadline);
runnable.call(call, now);
}
- return new DeleteTopicsResult(new HashMap<>(topicFutures));
+ return new HashMap<>(topicFutures);
Review comment:
I don't think this works because we use this map in getDeleteTopicsCall
where we can't use completeExceptionally on a KafkaFuture object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
