jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r661881338
########## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ########## @@ -1710,19 +1724,18 @@ public DeleteTopicsResult deleteTopics(final Collection<String> topicNames, Collections.emptyMap(), now, deadline); runnable.call(call, now); } - return new DeleteTopicsResult(new HashMap<>(topicFutures)); + return new HashMap<>(topicFutures); } - @Override - public DeleteTopicsWithIdsResult deleteTopicsWithIds(final Collection<Uuid> topicIds, - final DeleteTopicsOptions options) { + private Map<Uuid, KafkaFuture<Void>> handleDeleteTopicsUsingIds(final Collection<Uuid> topicIds, + final DeleteTopicsOptions options) { final Map<Uuid, KafkaFutureImpl<Void>> topicFutures = new HashMap<>(topicIds.size()); final List<Uuid> validTopicIds = new ArrayList<>(topicIds.size()); for (Uuid topicId : topicIds) { if (topicId.equals(Uuid.ZERO_UUID)) { KafkaFutureImpl<Void> future = new KafkaFutureImpl<>(); future.completeExceptionally(new UnknownTopicIdException("The given topic ID '" + - topicId + "' cannot be represented in a request.")); + topicId + "' cannot be represented in a request.")); Review comment: Ok. We can change to that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org