jolshan commented on a change in pull request #10892:
URL: https://github.com/apache/kafka/pull/10892#discussion_r661068251
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -1688,15 +1691,27 @@ void handleFailure(Throwable throwable) {
}
@Override
- public DeleteTopicsResult deleteTopics(final Collection<String> topicNames,
+ public DeleteTopicsResult deleteTopics(final TopicCollection topics,
final DeleteTopicsOptions options) {
+ DeleteTopicsResult result;
+ if (topics instanceof TopicIdCollection)
+ result = DeleteTopicsResult.ofTopicIds(new
HashMap<>(handleDeleteTopicsUsingIds(((TopicIdCollection) topics).topicIds(),
options)));
Review comment:
Many other admin client calls also follow this pattern with using
KafkaFutureImpl and copying the result to get KafkaFutures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
