ableegoldman commented on a change in pull request #11272:
URL: https://github.com/apache/kafka/pull/11272#discussion_r706092654
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##########
@@ -359,15 +362,24 @@ public final InternalTopologyBuilder
setApplicationId(final String applicationId
return this;
}
- public synchronized final InternalTopologyBuilder setStreamsConfig(final
StreamsConfig config) {
- Objects.requireNonNull(config, "config can't be null");
- this.config = config;
+ public synchronized final void setTopologyProperties(final Properties
props) {
+ this.topologyProperties = props;
+ }
- return this;
+ public synchronized final void setStreamsConfig(final StreamsConfig
config) {
Review comment:
@guozhangwang Played around with this a bit and was able to clean things
up nicely, plus address some other awkwardness that was bugging me. Worked out
great (just need to do some cleanup of the tests now...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
