ableegoldman commented on a change in pull request #11272:
URL: https://github.com/apache/kafka/pull/11272#discussion_r704907727



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java
##########
@@ -262,7 +262,7 @@ private StreamTask createActiveTask(final TaskId taskId,
             inputPartitions,
             topology,
             consumer,
-            config,
+            topologyMetadata.getTaskConfigFor(taskId),

Review comment:
       Can you clarify? Not sure if this is what you meant, but this should 
return the actual task configs, with any overrides already applied. I tried to 
keep all the override & config resolution logic inside the TopologyConfig class




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to