ableegoldman commented on a change in pull request #11272:
URL: https://github.com/apache/kafka/pull/11272#discussion_r704916241
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##########
@@ -611,6 +611,7 @@ public synchronized Topology build() {
*/
public synchronized Topology build(final Properties props) {
internalStreamsBuilder.buildAndOptimizeTopology(props);
+ internalTopologyBuilder.setTopologyProperties(props);
Review comment:
To clarify, these are the props that the user passes in when building
the topology, eg needed for `TOPOLOGY_OPTIMIZATION` which is the only actual
topology-level override today. So the overrides are only set the same as the
global props if the user decides to pass the same set of configs in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
