ableegoldman commented on a change in pull request #11272:
URL: https://github.com/apache/kafka/pull/11272#discussion_r706014148
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##########
@@ -359,15 +362,24 @@ public final InternalTopologyBuilder
setApplicationId(final String applicationId
return this;
}
- public synchronized final InternalTopologyBuilder setStreamsConfig(final
StreamsConfig config) {
- Objects.requireNonNull(config, "config can't be null");
- this.config = config;
+ public synchronized final void setTopologyProperties(final Properties
props) {
+ this.topologyProperties = props;
+ }
- return this;
+ public synchronized final void setStreamsConfig(final StreamsConfig
config) {
Review comment:
That all makes sense to me -- initially I was trying to make this just
work with the existing public API, but ultimately figured that even the concept
of "topology-level overrides" would require a KIP. If we're only dealing with
named topologies then we're free to do things the right way from the start --
thanks for the suggestions :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
