hachikuji commented on a change in pull request #11688:
URL: https://github.com/apache/kafka/pull/11688#discussion_r804247861
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java
##########
@@ -211,7 +211,13 @@ protected void onJoinComplete(int generation, String
memberId, String protocol,
}
@Override
- protected Map<String, ByteBuffer> performAssignment(String leaderId,
String protocol, List<JoinGroupResponseMember> allMemberMetadata) {
+ protected Map<String, ByteBuffer> onLeaderElected(String leaderId,
+ String protocol,
+
List<JoinGroupResponseMember> allMemberMetadata,
+ boolean skipAssignment) {
+ if (skipAssignment)
+ throw new IllegalStateException("Can't skip assignment because
Connect does not support static membership.");
Review comment:
Hmm, is it safe to ignore? What is the behavior if the client provides
the new assignment anyway when `skipAssignment` is set? It might be worse to
let connect generate a new assignment and let the coordinator ignore it. I
think I prefer to fail fast.
For what it's worth, I don't think we have a great support for test-only
assertions today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
