artemlivshits commented on a change in pull request #11688:
URL: https://github.com/apache/kafka/pull/11688#discussion_r804264986
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java
##########
@@ -211,7 +211,13 @@ protected void onJoinComplete(int generation, String
memberId, String protocol,
}
@Override
- protected Map<String, ByteBuffer> performAssignment(String leaderId,
String protocol, List<JoinGroupResponseMember> allMemberMetadata) {
+ protected Map<String, ByteBuffer> onLeaderElected(String leaderId,
+ String protocol,
+
List<JoinGroupResponseMember> allMemberMetadata,
+ boolean skipAssignment) {
+ if (skipAssignment)
+ throw new IllegalStateException("Can't skip assignment because
Connect does not support static membership.");
Review comment:
Ok, maybe I misunderstood the intent of `skipAssignment`, my
understanding was that was intended as an optimization on the client (so that
the static members wouldn't do assignment on taking leadership - previous
version of this optimization was that we didn't even tell the leader that it's
a leader to avoid doing assignment, which resulted in the problem partially
fixed by this change).
If it has other side effects, let's add a comment that explains that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
