dengziming commented on code in PR #12174: URL: https://github.com/apache/kafka/pull/12174#discussion_r877836361
########## core/src/main/scala/kafka/server/BrokerServer.scala: ########## @@ -93,6 +93,9 @@ class BrokerServer( this.logIdent = logContext.logPrefix + // VisibleForTesting + private[kafka] var controlledShutdownTimeoutMillis: Long = 5 * 60 * 1000L // 5 minutes Review Comment: This can solve the problem but is not very elegant, we can add a `shutdown(timeout)`, and use `Time` to compute a deadline, then we can use the deadline to compute a timeout for a controlled shutdown, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
