dengziming commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r879128740
##########
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##########
@@ -248,9 +248,11 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
index
}
- def killBroker(index: Int): Unit = {
+ def killBroker(index: Int): Unit = killBroker(index,
TimeUnit.SECONDS.toMinutes(5))
Review Comment:
Thanks for the update, can we unify these 2 methods into one:
`def killBroker(index: Int, timeoutMs: Long =
TimeUnit.SECONDS.toMinutes(5)): Unit = {...}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
