soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r879394247
##########
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##########
@@ -248,9 +248,11 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
index
}
- def killBroker(index: Int): Unit = {
+ def killBroker(index: Int): Unit = killBroker(index,
TimeUnit.SECONDS.toMinutes(5))
Review Comment:
Thanks for giving it another look. I didn't initially do this because the
method is also called from Java, where default parameters are not supported.
However, it's just one occurrence, so I've updated the caller in that case. I
also noticed that `toMinutes` here should be `toMillis` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
