soarez commented on code in PR #12174: URL: https://github.com/apache/kafka/pull/12174#discussion_r878056323
########## core/src/main/scala/kafka/server/BrokerServer.scala: ########## @@ -93,6 +93,9 @@ class BrokerServer( this.logIdent = logContext.logPrefix + // VisibleForTesting + private[kafka] var controlledShutdownTimeoutMillis: Long = 5 * 60 * 1000L // 5 minutes Review Comment: Thanks for reviewing this @dengziming. I agree it is not an elegant approach. And thanks for your suggestion, it seems to be in line with @hachikuji 's suggestion as well. I've updated this patch to follow your suggested approach. Please let me know if this is what you had in mind. However, I'm not very confident that this is better, since `KafkaServer` also has to implement the new `shutdown` variant and it has no use for the timeout. So it seems a bit strange to have an implementation where the timeout has to be ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
