On Thursday 29 April 2004 20:30, Miguel wrote:
> Sorry to hear that. I very much appreciate your taking the time to track
> it down.

No problem. CML parsing with SAX is still very much my hobby... I think I was 
the first to ever do it :)

> > Ok, the four CML files are now read. Only the <crystal> information is
> > not read at this moment, but going home now.

<crystal> reading is in and working now...

> I did a little more clean-up of the code.
>
> Mostly, I deleted my own (deprecated) code. Since the CML2 support that
> you implemented pulls all of the data values out of attributes, there was
> no need for the 'characters' handling.
>
> (I would rather remove it an add it back later if/when needed)

Ok, I already need it again :)

> I also did some other minor cleanup:
>
>  * renamed 'strings' -> 'tokens' in the atomArray handling
>
>  * changed the implementation so that the Atom[] atoms and the String[]
> tokens are reused ... rather than reallocated repeatedly.
>
>  * reduced the code size by combining a few calls

Please review the commited code, and optimize where possible...

Egon


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
Jmol-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to