On Thursday 29 April 2004 20:30, Miguel wrote: > I did a little more clean-up of the code.
Yes, I saw the commit message :) > Mostly, I deleted my own (deprecated) code. Since the CML2 support that > you implemented pulls all of the data values out of attributes, there was > no need for the 'characters' handling. > > (I would rather remove it an add it back later if/when needed) Yes, that's good thinking. > I also did some other minor cleanup: > > * renamed 'strings' -> 'tokens' in the atomArray handling Fine, I just copied the name you used :) > * changed the implementation so that the Atom[] atoms and the String[] > tokens are reused ... rather than reallocated repeatedly. Yes, I saw that you were using that... but I was not sure how to do that when the array growed in size... actually... how does that work? Yes, I'm not very good in writing performace efficient code... I really have no idea about the costs of certain types of operations... and therefore generally focus on easy to understand code... (at least for me :)... When I was hacking your code I already noticed the reuse... but see comment a few lines back ... > * reduced the code size by combining a few calls Yes, saw that... looks fine. > Q: If you have an atomArray with the various attributes as multi-token > strings, should it be an error if all of the strings are not the same > length? Not sure... but I think so. > I did not do anything with crystal support. Good. I'll try to have a look at it right now... Egon ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ Jmol-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jmol-developers
