Egon, >> Mmm.... still a bad XML parser... but it *is* a CML handler bug :(
Sorry to hear that. I very much appreciate your taking the time to track it down. >> After about 15 semi-randomly changing the CML file source, I traced it >> down >> to a bug in the handler... But, I think the parser *could* do with some >> better error handling! Agreed. > Ok, the four CML files are now read. Only the <crystal> information is not > read at this moment, but going home now. I did a little more clean-up of the code. Mostly, I deleted my own (deprecated) code. Since the CML2 support that you implemented pulls all of the data values out of attributes, there was no need for the 'characters' handling. (I would rather remove it an add it back later if/when needed) I also did some other minor cleanup: * renamed 'strings' -> 'tokens' in the atomArray handling * changed the implementation so that the Atom[] atoms and the String[] tokens are reused ... rather than reallocated repeatedly. * reduced the code size by combining a few calls Q: If you have an atomArray with the various attributes as multi-token strings, should it be an error if all of the strings are not the same length? I did not do anything with crystal support. Miguel ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ Jmol-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jmol-developers
