Hi, > Uncommented changes are worth less than those with comments. Let's combine our efforts to make it as easy and comfortable for everyone to add > meaningful comments, and we all gain from it.
Here's a possible patch: http://josm.openstreetmap.de/ticket/2442 It still enforces a commit comment but it provides a "default" comment, either a standard comment or the users last commit comment. Regards Karl -----Ursprüngliche Nachricht----- Von: josm-dev-boun...@openstreetmap.org [mailto:josm-dev-boun...@openstreetmap.org] Im Auftrag von Frederik Ramm Gesendet: Donnerstag, 23. April 2009 00:35 An: Ulf Lamping Cc: josm-dev Betreff: Re: [josm-dev] Commit message not empty Hi, Ulf Lamping wrote: >>> My fear is that especially newbies are prevented from uploading >>> stuff: "what do I have to add here?!?" - please remember: not >>> everyone has several years of subversion or wikipedia experience. >> >> We'll add a help button to explain. > > Making the GUI complicated and adding a Help button to explain the > complications is, well, not the best idea for improved user > friendliness IMHO. A text field where you have to enter text is not a complicated element. Not the field needs explaining, we need to explain why we want users to fill the field with text. This is not a complication of the user interface, but a complication of the process how one can contribute to OSM. Whether or not entering a commit comment is mandatory - the complexity remains, and the need to explain to the user why we want him to enter one. >> The problem is that Potlatch has to open the changeset before the >> user has done anything. And while I am a great fan of commit >> comments, requesting that the user describe what he is about to do, >> before he has even done it, would be going to far in my eyes! So >> there is no way to really enforce the policy with an online editor. > > There is *no* problem to add a changeset to an online editor. This is > simply just another indication that the potlatch model of not having a > "Save" button is the wrong way to go IMHO. Yes, I should have said "a live editor", not "an online editor". >> Oh, and there will be no "Yes" and "No" buttons. You will have to >> type the word. > > Would you be very upset if I write a JOSM plugin that uses Potlatch to > upload uncommented changes? ;-) Uncommented changes are worth less than those with comments. Let's combine our efforts to make it as easy and comfortable for everyone to add meaningful comments, and we all gain from it. Bye Frederik -- Frederik Ramm ## eMail frede...@remote.org ## N49°00'09" E008°23'33" _______________________________________________ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev _______________________________________________ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
