[
https://issues.apache.org/jira/browse/JSPWIKI-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588817#action_12588817
]
Harry Metske commented on JSPWIKI-50:
-------------------------------------
Hmm, quite a different response than the one from 05/Dec/07 :-)
Actually CachingProvider has 4 caches, textCache, historyCache, and then there
is the "normal" cache with it's negCache (and also a Hashmap m_allItems), to me
it sounds a little bit caching overkill, and I still don't understand how
negCache works.
About the CachingAttachmentProvider, it already had a cache with pagename as
key, but this cache contains Collections of attachment versions. This cache is
not initially populated, and should grow over time. I don't know how much
benefit that gives us now.
The new attCache I put in, was specifically targeted at solving this JIRA issue
(speeding up RecentChanges). Which resulted in only caching the current version
of attachments, and initially populating the cache during startup.
Measurements and personal experience have shown a good performance improvement,
see also above measurement results.
It might have been possible to use the already existing cache by extracting the
current versions, but looked to me more complex and less performing than adding
a separate cache, also initially populating the existing cache with all
versions of all attachments might not be very efficient.
But I wasn't the original writer of both classes, so I always welcome better
solutions.
Kind regards,
Harry
> RecentChanges plugin is slow
> ----------------------------
>
> Key: JSPWIKI-50
> URL: https://issues.apache.org/jira/browse/JSPWIKI-50
> Project: JSPWiki
> Issue Type: Improvement
> Components: Plugins
> Reporter: Janne Jalkanen
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 2.8
>
> Attachments: CachedAttachmentCollector.java,
> CachingAttachmentProvider.patch, PageTimeComparator.patch, Screenshot-20252
> msec -- -tmp-jip-profile.xml.png
>
>
> RecentChanges plugin gets awfully slow once the repository gets big enough.
> It might be a good idea to cache something or do some other performance
> optimizations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
