CC: [email protected] CC: [email protected] TO: Krzysztof Kozlowski <[email protected]> CC: Julia Lawall <[email protected]> CC: Wolfgang Grandegger <[email protected]> CC: "Marc Kleine-Budde" <[email protected]> CC: Jakub Kicinski <[email protected]> CC: Vincent Mailhol <[email protected]> CC: [email protected] CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/net/can/spi/hi311x.c:759:7-27: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: b8a98b6bf66ae35361e987333233d07241642909 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives :::::: branch date: 4 hours ago :::::: commit date: 7 months ago Please take the patch only if it's a positive warning. Thanks! hi311x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/can/spi/hi311x.c +++ b/drivers/net/can/spi/hi311x.c @@ -757,7 +757,7 @@ static int hi3110_open(struct net_device priv->tx_len = 0; ret = request_threaded_irq(spi->irq, NULL, hi3110_can_ist, - flags, DEVICE_NAME, priv); + flags | IRQF_ONESHOT, DEVICE_NAME, priv); if (ret) { dev_err(&spi->dev, "failed to acquire irq %d\n", spi->irq); goto out_close; _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
