CC: [email protected] CC: [email protected] TO: Krzysztof Kozlowski <[email protected]> CC: Julia Lawall <[email protected]> CC: Lee Jones <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/mfd/wm8350-irq.c:527:7-27: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 6f513529296fd4f696afb4354c46508abe646541 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives :::::: branch date: 17 hours ago :::::: commit date: 7 months ago Please take the patch only if it's a positive warning. Thanks! wm8350-irq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/mfd/wm8350-irq.c +++ b/drivers/mfd/wm8350-irq.c @@ -524,7 +524,8 @@ int wm8350_irq_init(struct wm8350 *wm835 irq_clear_status_flags(cur_irq, IRQ_NOREQUEST | IRQ_NOPROBE); } - ret = request_threaded_irq(irq, NULL, wm8350_irq, flags, + ret = request_threaded_irq(irq, NULL, wm8350_irq, + flags | IRQF_ONESHOT, "wm8350", wm8350); if (ret != 0) dev_err(wm8350->dev, "Failed to request IRQ: %d\n", ret); _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
