CC: [email protected] CC: [email protected] TO: Krzysztof Kozlowski <[email protected]> CC: Julia Lawall <[email protected]> CC: MyungJoo Ham <[email protected]> CC: Chanwoo Choi <[email protected]> CC: [email protected]
From: kernel test robot <[email protected]> drivers/extcon/extcon-max77843.c:907:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a763d5a5abd65797aec3dd1bf01fe2ccbec32967 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives :::::: branch date: 5 hours ago :::::: commit date: 7 months ago Please take the patch only if it's a positive warning. Thanks! extcon-max77843.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/extcon/extcon-max77843.c +++ b/drivers/extcon/extcon-max77843.c @@ -905,7 +905,8 @@ static int max77843_muic_probe(struct pl muic_irq->virq = virq; ret = devm_request_threaded_irq(&pdev->dev, virq, NULL, - max77843_muic_irq_handler, IRQF_NO_SUSPEND, + max77843_muic_irq_handler, + IRQF_NO_SUSPEND | IRQF_ONESHOT, muic_irq->name, info); if (ret) { dev_err(&pdev->dev, _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
