CC: [email protected] CC: [email protected] TO: Krzysztof Kozlowski <[email protected]> CC: Julia Lawall <[email protected]> CC: Dmitry Torokhov <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/input/keyboard/twl4030_keypad.c:413:9-34: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a763d5a5abd65797aec3dd1bf01fe2ccbec32967 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives :::::: branch date: 5 hours ago :::::: commit date: 7 months ago Please take the patch only if it's a positive warning. Thanks! twl4030_keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/keyboard/twl4030_keypad.c +++ b/drivers/input/keyboard/twl4030_keypad.c @@ -411,7 +411,7 @@ static int twl4030_kp_probe(struct platf * NOTE: we assume this host is wired to TWL4040 INT1, not INT2 ... */ error = devm_request_threaded_irq(&pdev->dev, kp->irq, NULL, do_kp_irq, - 0, pdev->name, kp); + IRQF_ONESHOT, pdev->name, kp); if (error) { dev_info(kp->dbg_dev, "request_irq failed for irq no=%d: %d\n", kp->irq, error); _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
