CC: [email protected] CC: [email protected] TO: Krzysztof Kozlowski <[email protected]> CC: Julia Lawall <[email protected]> CC: Support Opensource <[email protected]> CC: Liam Girdwood <[email protected]> CC: Mark Brown <[email protected]> CC: [email protected]
From: kernel test robot <[email protected]> drivers/regulator/slg51000-regulator.c:480:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4d66020dcef83314092f2c8c89152a8d122627e2 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives :::::: branch date: 3 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! slg51000-regulator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/regulator/slg51000-regulator.c +++ b/drivers/regulator/slg51000-regulator.c @@ -479,8 +479,7 @@ static int slg51000_i2c_probe(struct i2c if (chip->chip_irq) { ret = devm_request_threaded_irq(dev, chip->chip_irq, NULL, slg51000_irq_handler, - (IRQF_TRIGGER_HIGH | - IRQF_ONESHOT), + (IRQF_TRIGGER_HIGH | IRQF_ONESHOT) | IRQF_ONESHOT, "slg51000-irq", chip); if (ret != 0) { dev_err(dev, "Failed to request IRQ: %d\n", _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
