CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: linux-ker...@vger.kernel.org
TO: Krzysztof Kozlowski <k...@kernel.org>
CC: Julia Lawall <julia.law...@inria.fr>
CC: Liam Girdwood <lgirdw...@gmail.com>
CC: Mark Brown <broo...@kernel.org>
CC: Matthias Brugger <matthias....@gmail.com>
CC: linux-ker...@vger.kernel.org
CC: linux-arm-ker...@lists.infradead.org
CC: linux-media...@lists.infradead.org
From: kernel test robot <l...@intel.com>
drivers/regulator/mt6360-regulator.c:386:8-33: WARNING: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
CC: Krzysztof Kozlowski <krzysztof.kozlow...@canonical.com>
Reported-by: kernel test robot <l...@intel.com>
Signed-off-by: kernel test robot <l...@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: c00c5e1d157bec0ef0b0b59aa5482eb8dc7e8e49
commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot:
reduce the severity due to false positives
:::::: branch date: 14 hours ago
:::::: commit date: 12 months ago
Please take the patch only if it's a positive warning. Thanks!
drivers/regulator/mt6360-regulator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/regulator/mt6360-regulator.c
+++ b/drivers/regulator/mt6360-regulator.c
@@ -383,7 +383,8 @@ static int mt6360_regulator_irq_register
if (irq < 0)
return irq;
- ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
irq_desc->handler, 0,
+ ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
irq_desc->handler,
+ IRQF_ONESHOT,
irq_desc->name, rdev);
if (ret) {
dev_err(&pdev->dev, "Fail to request %s irq\n",
irq_desc->name);
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
