CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Krzysztof Kozlowski <k...@kernel.org>
CC: Julia Lawall <julia.law...@inria.fr>
CC: Maximilian Luz <luzmaximil...@gmail.com>
CC: Hans de Goede <hdego...@redhat.com>
CC: Mark Gross <mgr...@linux.intel.com>
CC: platform-driver-...@vger.kernel.org
CC: linux-ker...@vger.kernel.org
From: kernel test robot <l...@intel.com>
drivers/platform/surface/surface_hotplug.c:180:10-35: WARNING: Threaded IRQ
with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
CC: Krzysztof Kozlowski <krzysztof.kozlow...@canonical.com>
Reported-by: kernel test robot <l...@intel.com>
Signed-off-by: kernel test robot <l...@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: dcb85f85fa6f142aae1fe86f399d4503d49f2b60
commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot:
reduce the severity due to false positives
:::::: branch date: 11 hours ago
:::::: commit date: 9 months ago
Please take the patch only if it's a positive warning. Thanks!
surface_hotplug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/platform/surface/surface_hotplug.c
+++ b/drivers/platform/surface/surface_hotplug.c
@@ -178,7 +178,8 @@ static int shps_setup_irq(struct platfor
return -ENOMEM;
status = devm_request_threaded_irq(&pdev->dev, irq, NULL,
shps_handle_irq,
- flags, irq_name, pdev);
+ flags | IRQF_ONESHOT, irq_name,
+ pdev);
if (status)
return status;
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
