CC: [email protected] CC: [email protected] TO: Krzysztof Kozlowski <[email protected]> CC: Julia Lawall <[email protected]> CC: Lee Jones <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/mfd/arizona-irq.c:374:7-27: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dcb85f85fa6f142aae1fe86f399d4503d49f2b60 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives :::::: branch date: 11 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! arizona-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mfd/arizona-irq.c +++ b/drivers/mfd/arizona-irq.c @@ -372,7 +372,7 @@ int arizona_irq_init(struct arizona *ari } ret = request_threaded_irq(arizona->irq, NULL, arizona_irq_thread, - flags, "arizona", arizona); + flags | IRQF_ONESHOT, "arizona", arizona); if (ret != 0) { dev_err(arizona->dev, "Failed to request primary IRQ %d: %d\n", _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
