https://bugs.kde.org/show_bug.cgi?id=525619
--- Comment #12 from Conn O'Griofa <[email protected]> --- (In reply to Zamundaaa from comment #11) > > Sunshine's latest master branch will try fixed rate by default - which > > works fine - but I patched it on my local build to try variable rate, just > > to see how this commit impacted pacing. When doing this, Sunshine connects > > to a black screen and then fails to initialize on restart, because kwin > > itself seems to be crashing. > I had a logic error in the MR, thanks for catching that. I pushed a fix to > the MR. Unfortunately the the updated MR didn't resolve the crashing. This solves the issue, but I'm uncertain if it's fully correct: ``` diff --git a/src/plugins/screencast/screencaststream.cpp b/src/plugins/screencast/screencaststream.cpp index 9a231d1def..6584a051cd 100644 --- a/src/plugins/screencast/screencaststream.cpp +++ b/src/plugins/screencast/screencaststream.cpp @@ -411,7 +411,7 @@ bool ScreenCastStream::init() uint ScreenCastStream::framerate() { constexpr uint32_t maxFramerate = 1'000'000; - if (m_pwStream && m_videoFormat.max_framerate.denom != 0) { + if (m_pwStream && m_videoFormat.max_framerate.num != 0 && m_videoFormat.max_framerate.denom != 0) { return std::min((1000 * m_videoFormat.max_framerate.num) / m_videoFormat.max_framerate.denom, maxFramerate); } ``` With the above guard added, variable rate doesn't cause kwin to crash and pacing seems OK in-game with the testcase. Desktop animations are still not paced correctly (squash/stretch/scale run at 30fps), but that's not directly related to this bug. Retesting your updated MR (with or without my crash guard added) with Sunshine set back to fixed rate negotiation still resolves the issue. -- You are receiving this mail because: You are watching all bug changes.
