> On March 22, 2011, 10:14 p.m., Parker Coates wrote: > > kunitconversion/length.cpp, line 146 > > <http://git.reviewboard.kde.org/r/100923/diff/1/?file=12695#file12695line146> > > > > You missed "Angstrom". Accents are too hard for some of us. :) Plural > > forms might be good too.
Ångström does not have plural forms, like Hertz, Ampère, or Kelvin :) I agree that the accent-free form should be included, though. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100923/#review2109 ----------------------------------------------------------- On March 22, 2011, 8:43 p.m., Etienne Rebetez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100923/ > ----------------------------------------------------------- > > (Updated March 22, 2011, 8:43 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > Hi, > Just adding Ångström as a lenght unit to kunitcoversion. > I plan to integrate KUnitConversion into Kalzium. Since the lenght values of > elements in ements.xml are stored in Ångström i need that unit to. > > http://en.wikipedia.org/wiki/%C3%85ngstr%C3%B6m > > Etienne > > > Diffs > ----- > > kunitconversion/converter.h f52b602 > kunitconversion/length.cpp d734443 > > Diff: http://git.reviewboard.kde.org/r/100923/diff > > > Testing > ------- > > > Thanks, > > Etienne > >
