----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/ -----------------------------------------------------------
Review request for kdelibs and David Faure. Description ------- At first i wasn't intending to even ask a reviewrequest for this because i want to fix an issue that is well described in my thread: "KDirWatch bug and the analysis. Help is welcome!" on kde-core-devel. However, while starting on fixing that issue i noticed that this would be a nice small improvement to have. It also prevents one stat call that was used to determine if "entry" was a file or folder, but inotify already gives us that information. Diffs ----- kdecore/io/kdirwatch.cpp 95ee3d3 Diff: http://git.reviewboard.kde.org/r/111870/diff/ Testing ------- Compiles just fine. Runs fine, i haven't seen any issues thus far. Oh and it passes all kio test cases but i specially note the following: kdirwatchtest kdirlistertest kdirmodeltest Thanks, Mark Gaiser
