----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review61502 -----------------------------------------------------------
dolphin/src/dolphinmainwindow.h <https://git.reviewboard.kde.org/r/118994/#comment42814> Move it to DolphinRecentTabsMenu dolphin/src/dolphinmainwindow.cpp <https://git.reviewboard.kde.org/r/118994/#comment42815> Why? This case should not happen, please add a Q_ASSERT instead dolphin/src/dolphinmainwindow.cpp <https://git.reviewboard.kde.org/r/118994/#comment42816> [] -> .at() dolphin/src/dolphinmainwindow.cpp <https://git.reviewboard.kde.org/r/118994/#comment42817> Please add a new method to DolphinRecentTabsMenu which returns true if there are closed tabs available for restoring and false otherwise, so that we get rid of all these size() < 3 checks in multiple places. We can use the same method in DolphinRecentTabsMenu::handleAction to disable the recent tabs menu. dolphin/src/dolphinmainwindow.cpp <https://git.reviewboard.kde.org/r/118994/#comment42818> KAction* undoCloseTab - Emmanuel Pescosta On July 2, 2014, 3:59 p.m., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118994/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 3:59 p.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Bugs: 336818 > http://bugs.kde.org/show_bug.cgi?id=336818 > > > Repository: kde-baseapps > > > Description > ------- > > Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with > the help of Go->'Recently closed tabs' menu). > > > Diffs > ----- > > dolphin/src/dolphinmainwindow.h acf60a4 > dolphin/src/dolphinmainwindow.cpp c60951d > dolphin/src/dolphinui.rc 52826bb > > Diff: https://git.reviewboard.kde.org/r/118994/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > >
