> On July 2, 2014, 11:30 p.m., Emmanuel Pescosta wrote: > > dolphin/src/dolphinmainwindow.cpp, lines 1136-1138 > > <https://git.reviewboard.kde.org/r/118994/diff/3/?file=286667#file286667line1136> > > > > Why? > > > > This case should not happen, please add a Q_ASSERT instead
It would happen if the user cleared the history from the "Recently closed tabs" menu. Anyway it doesnt apply to the new patch > On July 2, 2014, 11:30 p.m., Emmanuel Pescosta wrote: > > dolphin/src/dolphinmainwindow.cpp, line 1139 > > <https://git.reviewboard.kde.org/r/118994/diff/3/?file=286667#file286667line1139> > > > > [] -> .at() I never knew they were different, thought they were the same. - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review61502 ----------------------------------------------------------- On July 5, 2014, 4:45 p.m., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118994/ > ----------------------------------------------------------- > > (Updated July 5, 2014, 4:45 p.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Bugs: 336818 > http://bugs.kde.org/show_bug.cgi?id=336818 > > > Repository: kde-baseapps > > > Description > ------- > > Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with > the help of Go->'Recently closed tabs' menu). > > > Diffs > ----- > > dolphin/src/dolphinmainwindow.h acf60a4 > dolphin/src/dolphinmainwindow.cpp c60951d > dolphin/src/dolphinrecenttabsmenu.h 34d4153 > dolphin/src/dolphinrecenttabsmenu.cpp a39f994 > dolphin/src/dolphinui.rc 52826bb > > Diff: https://git.reviewboard.kde.org/r/118994/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > >
