----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review61642 -----------------------------------------------------------
dolphin/src/dolphinrecenttabsmenu.cpp <https://git.reviewboard.kde.org/r/118994/#comment42895> Is it safe to 'delete' a QObject? shouldnt we be using deleteLater() - Arjun Ak On July 5, 2014, 4:49 p.m., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118994/ > ----------------------------------------------------------- > > (Updated July 5, 2014, 4:49 p.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Bugs: 336818 > http://bugs.kde.org/show_bug.cgi?id=336818 > > > Repository: kde-baseapps > > > Description > ------- > > Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with > the help of Go->'Recently closed tabs' menu). > > > Diffs > ----- > > dolphin/src/dolphinui.rc 52826bb > dolphin/src/dolphinrecenttabsmenu.h 34d4153 > dolphin/src/dolphinrecenttabsmenu.cpp a39f994 > dolphin/src/dolphinmainwindow.h acf60a4 > dolphin/src/dolphinmainwindow.cpp c60951d > > Diff: https://git.reviewboard.kde.org/r/118994/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > >