----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review61704 -----------------------------------------------------------
dolphin/src/dolphinmainwindow.h <https://git.reviewboard.kde.org/r/118994/#comment42939> "var_type var_name" for parameters dolphin/src/dolphinmainwindow.cpp <https://git.reviewboard.kde.org/r/118994/#comment42947> Maybe add the (in this case unneeded) "> 0" check to make it more obvious when we enable/disable this action. dolphin/src/dolphinmainwindow.cpp <https://git.reviewboard.kde.org/r/118994/#comment42941> Add one space before this, so that recentTabsMenu and this are justified dolphin/src/dolphinmainwindow.cpp <https://git.reviewboard.kde.org/r/118994/#comment42942> space after , dolphin/src/dolphinrecenttabsmenu.h <https://git.reviewboard.kde.org/r/118994/#comment42943> "var_type var_name" for parameters - Emmanuel Pescosta On July 6, 2014, 12:46 p.m., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118994/ > ----------------------------------------------------------- > > (Updated July 6, 2014, 12:46 p.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Bugs: 336818 > http://bugs.kde.org/show_bug.cgi?id=336818 > > > Repository: kde-baseapps > > > Description > ------- > > Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with > the help of Go->'Recently closed tabs' menu). > > > Diffs > ----- > > dolphin/src/dolphinmainwindow.h 7c3bff4 > dolphin/src/dolphinmainwindow.cpp d9fe645 > dolphin/src/dolphinrecenttabsmenu.h 34d4153 > dolphin/src/dolphinrecenttabsmenu.cpp a39f994 > dolphin/src/dolphinui.rc 52826bb > > Diff: https://git.reviewboard.kde.org/r/118994/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > >
