dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
Sorry, just spotted one last typo (and two missing @since), feel free to push after fixing. INLINE COMMENTS > udsentrytest.cpp:231 > +{ > + // Create a temporaty file. Just to make a UDSEntry further down. > + QTemporaryFile file; Typo: tempora*r*y > udsentry.h:94 > + /** > + * Move constructor > + */ @since 5.44 > udsentry.h:104 > + /** > + * Move assignment > + */ @since 5.44 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg, dfaure Cc: apol, #frameworks, michaelh