----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110276/#review31915 -----------------------------------------------------------
Ship it! Code is fine. UI does get that boxes in boxes look, but at the same time it's also neater and tidier so ship it from me. Wait for other comments though. - David Edmundson On May 2, 2013, 9:07 p.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110276/ > ----------------------------------------------------------- > > (Updated May 2, 2013, 9:07 p.m.) > > > Review request for Telepathy, KDE Usability, David Edmundson, and Martin > Klapetek. > > > Description > ------- > > This patch revamps the settings UI of the kded module. Especially, it removes > the "flat" flag from the group boxes, and also removes lots of spacers. But > talk doesn't really help with UI changes, so you'd better look at the > screenshot below ;) > > Additionally, I'd like to add a dialog->resize(700, 640) to > ContactListWidget::showSettingsKCM() in contact-list-widget.cpp in > ktp-contactlist (the function which opens the dialog), but I don't want to > open a seperate review for that. > > > Diffs > ----- > > config/telepathy-kded-config.cpp 50c176d > config/telepathy-kded-config.ui 54ebc54 > > Diff: http://git.reviewboard.kde.org/r/110276/diff/ > > > Testing > ------- > > The settings dialog still seems to work fine. > > > File Attachments > ---------------- > > Old (left) and new (right) settings dialog, with their respective default > sizes > > http://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/ktp-settings.png > > > Thanks, > > Sven Brauch > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
