> On May 2, 2013, 10:20 p.m., Heiko Tietze wrote:
> > Please make sure that left and right spacing fits design specification (if
> > we have any). And the edit fields looks a little bit narrow at first glance.
> > From a usability point of view I would always place edits below their
> > caption. That makes translation easier and leads to better alignment. But
> > in this case it would be weird to break lines.
> > I would sort the panels differently, ie. "Now playing" to the bottom (or
> > into another tab).
> > "Auto offline": Isn't it part of the "Auto away" area? ("Sorry, it isn't.")
> > To prevent this mistake you could rename it to "Contact list behaviour".
> > But make this feature really sense?
> > Take care about short-cuts: It's not easy to access the away message, for
> > instance. Better you provide Alt+M/E/R per "With &message" and "With
> > m&essage" as well as "Afte&r" (second item), or the like.
> > "Now playing" looks quite difficult to use. If you decide to move it into
> > another tab you could add assistance features or at least some help.
> >
> > After all, settings don't have a consistent layout, so it's hard to give a
> > good advice. Ship it, if you don't worry about a particular problem.
> >
> > >Additionally, I'd like to add a dialog->resize(700, 640) to
> > >ContactListWidget::showSettingsKCM()
> > Is it a predefined window size? Sounds evil.
Hi Heiko,
I'm sorry to respond with many questions, but I can't help it ;)
> Please make sure that left and right spacing fits design specification
It uses the default spacings, so shouldn't this be decided by the theme? i.e.
can anything be wrong if I never alter the pre-set spacings?
> And the edit fields looks a little bit narrow at first glance.
Sorry, which ones do you mean? All edit fields are much wider than before,
aren't they?
> I would sort the panels differently, ie. "Now playing" to the bottom
Good idea, I already reordered it a bit, but I guess you're right that the
current sorting isn't optimal yet.
> To prevent this mistake you could rename it to "Contact list behaviour".
I will do that too.
> But make this feature really sense?
Yes, I think, since if you don't have any presence widgets enabled, if you
close the contact list you'll still be online with no obvious way to go offline
(or even notice you're still online). So in that case it would make sense.
Given the fact that there is not really any usable cross-desktop presence
widgets, I think this feature should be kept.
> Take care about short-cuts:
Oh, another thing I totally overlooked ;) I'll fix them.
> If you decide to move it into another tab you could add assistance features
> or at least some help.
I'm unsure how you'd call the two tabs so it makes sense... I can't really come
up with anything useful. "General" and "Status" sound stupid and it's not very
obvious what they contain :(
> Is it a predefined window size? Sounds evil.
Okay. But, how does one do that, setting a recommended initial size for the
dialog? The current size is too large.
Thanks for reviewing!
Cheers
- Sven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110276/#review31921
-----------------------------------------------------------
On May 2, 2013, 9:07 p.m., Sven Brauch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110276/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 9:07 p.m.)
>
>
> Review request for Telepathy, KDE Usability, David Edmundson, and Martin
> Klapetek.
>
>
> Description
> -------
>
> This patch revamps the settings UI of the kded module. Especially, it removes
> the "flat" flag from the group boxes, and also removes lots of spacers. But
> talk doesn't really help with UI changes, so you'd better look at the
> screenshot below ;)
>
> Additionally, I'd like to add a dialog->resize(700, 640) to
> ContactListWidget::showSettingsKCM() in contact-list-widget.cpp in
> ktp-contactlist (the function which opens the dialog), but I don't want to
> open a seperate review for that.
>
>
> Diffs
> -----
>
> config/telepathy-kded-config.cpp 50c176d
> config/telepathy-kded-config.ui 54ebc54
>
> Diff: http://git.reviewboard.kde.org/r/110276/diff/
>
>
> Testing
> -------
>
> The settings dialog still seems to work fine.
>
>
> File Attachments
> ----------------
>
> Old (left) and new (right) settings dialog, with their respective default
> sizes
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/ktp-settings.png
>
>
> Thanks,
>
> Sven Brauch
>
>
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
